matthew
/
vanrijn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix accumulation buffer #1

New Issue
Closed
opened 2024-06-04 00:39:38 +00:00 by matthew · 1 comment
matthew commented 2024-06-04 00:39:38 +00:00
Owner
Copy Link

I'm pretty sure the accumulation buffer isn't doing anything after a few iterations. It's hard to say because the rate of change is expected to slow down over time as the values converge but after a few updates, if you watch the window and just focus on one area the pixels don't seem to be changing at all.

I didn't actually document accumulation_buffer.rs, but it appears to be using Kahan summation.

I'm pretty sure the accumulation buffer isn't doing anything after a few iterations. It's hard to say because the rate of change is expected to slow down over time as the values converge but after a few updates, if you watch the window and just focus on one area the pixels don't seem to be changing at all. I didn't actually document `accumulation_buffer.rs`, but it appears to be using Kahan summation.
matthew commented 2025-03-22 00:02:34 +00:00
Author
Owner
Copy Link

After carefully reading through the Kahan suimmation code, the summation was fine and the problem actually turned out to be the way I was calculating the final colour from the summed colours and weights.

After carefully reading through the Kahan suimmation code, the summation was fine and the problem actually turned out to be the way I was calculating the final colour from the summed colours and weights.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
glass-bunny
github-build-action
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: matthew/vanrijn#1
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?