From 29dc3b6a37b718bad917401f6aad33d8aabec790 Mon Sep 17 00:00:00 2001 From: Matthew Gordon Date: Fri, 19 Jun 2020 00:00:12 -0400 Subject: [PATCH] Fix a typo that caused artifacts with ReflectiveMaterial --- src/materials/reflective_material.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/materials/reflective_material.rs b/src/materials/reflective_material.rs index f093f1f..c38d103 100644 --- a/src/materials/reflective_material.rs +++ b/src/materials/reflective_material.rs @@ -19,8 +19,8 @@ impl Material for ReflectiveMaterial { let reflection_strength = self.reflection_strength; Box::new( move |w_o: Vector3, w_i: Vector3, colour_in: ColourRgbF| { - if w_i.z < T::zero() || w_o.z < T::zero() { - ColourRgbF::new(T::zero(), T::one(), T::one()) + if w_i.z <= T::zero() || w_o.z <= T::zero() { + ColourRgbF::new(T::zero(), T::zero(), T::zero()) } else { let reflection_vector = Vector3::new(-w_o.x, -w_o.y, w_o.z); let reflection_colour = colour_in * reflection_strength;